-
-
Notifications
You must be signed in to change notification settings - Fork 19
Update README with Configure Custom Logger & Enable Logging #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated logging configuration to use ComposeStabilityAnalyzer instead of LoggerProvider for debug builds.
WalkthroughDocumentation updated to replace the public API reference from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
278-278: Fix markdown lint warning: use heading syntax instead of emphasis.The "Important Note" uses bold emphasis (
**...**) instead of proper heading syntax. Convert to a markdown heading for better semantic structure and to resolve the MD036 linting violation.-**Important Note** +### Important NoteThis also improves document structure and makes the note visually distinct as a section header rather than emphasized text.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md
278-278: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
🔇 Additional comments (1)
README.md (1)
273-273: API reference updated correctly.The changes replacing
LoggerProviderwithComposeStabilityAnalyzeralign with the actual public API and address the confusing documentation that referenced a non-existent public class. Both the code example and the accompanying note are now consistent with the implementation.Also applies to: 281-281
skydoves
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
🎯 Goal
I have updated the README because the logging setup code shown in it differs from the actual implementation, which could cause confusion for developers using this plugin.
🛠 Implementation details
https://github.com/skydoves/compose-stability-analyzer?tab=readme-ov-file#configure-custom-logger--enable-logging
AS IS
Important Note
TO BE
Important Note
✍️ Explain examples
When writing the code as above and building it, the following error occurs.
refernece
compose-stability-analyzer/stability-runtime/src/commonMain/kotlin/com/skydoves/compose/stability/runtime/RecompositionLogger.kt
Line 163 in e5ea4d8
https://github.com/YAPP-Github/Reed-Android/pull/211/files
Question
I'm wondering if
LoggerProvideris not an actual class name but rather a descriptive term that encompasses both the default logger and custom loggers.I could only find the name
LoggerProviderin theLoggerProviderTestclass and comments within the project.Thank you for creating such an excellent plugin!
Summary by CodeRabbit